Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(swarm): remove unused DialError::ConnectionIo variant #3374

Merged
merged 8 commits into from
Jan 26, 2023
Merged

feat(swarm): remove unused DialError::ConnectionIo variant #3374

merged 8 commits into from
Jan 26, 2023

Conversation

thomaseizinger
Copy link
Contributor

@thomaseizinger thomaseizinger commented Jan 24, 2023 •
edited
Loading

Description

This variant is never constructed.

Notes

Links to any relevant issues

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@thomaseizinger thomaseizinger requested review from jxs and mxinden January 24, 2023 02:56
@thomaseizinger thomaseizinger mentioned this pull request Jan 24, 2023
Merged
4 tasks
@thomaseizinger thomaseizinger marked this pull request as draft January 24, 2023 04:18
jxs
jxs approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Base automatically changed from 2824-remove-unused-error to master January 26, 2023 05:26
@thomaseizinger thomaseizinger marked this pull request as ready for review January 26, 2023 05:48
@mergify
Copy link
Contributor

mergify bot commented Jan 26, 2023

This pull request has merge conflicts. Could you please resolve them @thomaseizinger? 🙏

@thomaseizinger
Copy link
Contributor Author

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Jan 26, 2023

refresh

✅ Pull request refreshed

@mergify mergify bot merged commit 14825c7 into master Jan 26, 2023
@mergify mergify bot deleted the 2824-remove-unused-connection-error branch January 26, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxs jxs jxs approved these changes

@mxinden mxinden Awaiting requested review from mxinden

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomaseizinger @jxs